improve: split input from input-item #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@silentcloud, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pingan1927, @yiminghe and @paranoidjk to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #1225 +/- ##
=========================================
+ Coverage 69.76% 69.8% +0.04%
=========================================
Files 218 219 +1
Lines 4131 4150 +19
Branches 1218 1223 +5
=========================================
+ Hits 2882 2897 +15
- Misses 1248 1252 +4
Partials 1 1
Continue to review full report at Codecov.
|
pingan1927
reviewed
Apr 27, 2017
components/input-item/index.web.tsx
Outdated
| @@ -260,8 +182,6 @@ class InputItem extends React.Component<InputItemProps, any> { | |||
| name={name} | |||
| placeholder={placeholder} | |||
| onChange={this.onInputChange} | |||
| onBlur={this.onInputBlur} | |||
| onFocus={this.onInputFocus} | |||
| readOnly={!editable} | |||
| disabled={disabled} | |||
| /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for your contribution! :-)
Please makes sure these boxes are checked before submitting your PR, thank you!
npm run lintand fix those errors before submitting in order to keep consistent code style.