-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dot to interface TabBarItemProps #1209
Conversation
@cncolder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @silentcloud to be a potential reviewer. |
BTW. Should |
children相关的要整体改,需要升级ts |
ci 挂了 ,处理一下 |
@paranoidjk 是 accordion 样式引起的问题 <div
aria-expanded="false"
- class="am-accordion-header"
+ class="am-accordion-header "
role="tab"
> |
如果是符合预期的就 npm run web -- -u ,不符合预期就修改下。这里应该是snapshot不变的 |
@paranoidjk 我本地只有一个 [email protected] 直接在 master 上跑 这3处还和 CI 上面的位置不同,CI 上的两处 FAIL 都在 accordion |
@cncolder 确认分支和代码对的前提下,重装依赖试试。另外注意是否有全局安装的 typescript 等版本不同 |
稍我更新master的snapshot你再rebase下 react-component/collapse#66 |
Codecov Report
@@ Coverage Diff @@
## master #1209 +/- ##
=======================================
Coverage 69.77% 69.77%
=======================================
Files 218 218
Lines 4129 4129
Branches 1217 1217
=======================================
Hits 2881 2881
Misses 1247 1247
Partials 1 1
Continue to review full report at Codecov.
|
This prop pass through to Tab. It's documented but missing here.
First of all, thanks for your contribution! :-)
Please makes sure these boxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.