Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dot to interface TabBarItemProps #1209

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Conversation

cncolder
Copy link
Contributor

@cncolder cncolder commented Apr 25, 2017

This prop pass through to Tab. It's documented but missing here.

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@mention-bot
Copy link

@cncolder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @silentcloud to be a potential reviewer.

@cncolder
Copy link
Contributor Author

cncolder commented Apr 25, 2017

BTW. Should TabBarProps.children be children?: any;?

@paranoidjk
Copy link
Contributor

children相关的要整体改,需要升级ts

microsoft/TypeScript#13618

@paranoidjk
Copy link
Contributor

ci 挂了 ,处理一下

@cncolder
Copy link
Contributor Author

@paranoidjk 是 accordion 样式引起的问题

   <div
         aria-expanded="false"
-        class="am-accordion-header"
+        class="am-accordion-header "
         role="tab"
       >

@paranoidjk
Copy link
Contributor

如果是符合预期的就 npm run web -- -u ,不符合预期就修改下。这里应该是snapshot不变的

@cncolder
Copy link
Contributor Author

@paranoidjk 我本地只有一个 [email protected]

直接在 master 上跑 npm run test:web 就有3处 FAIL,swipe-action stepper list

这3处还和 CI 上面的位置不同,CI 上的两处 FAIL 都在 accordion

@paranoidjk
Copy link
Contributor

@cncolder 确认分支和代码对的前提下,重装依赖试试。另外注意是否有全局安装的 typescript 等版本不同

@paranoidjk
Copy link
Contributor

稍我更新master的snapshot你再rebase下 react-component/collapse#66

@codecov
Copy link

codecov bot commented Apr 26, 2017

Codecov Report

Merging #1209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1209   +/-   ##
=======================================
  Coverage   69.77%   69.77%           
=======================================
  Files         218      218           
  Lines        4129     4129           
  Branches     1217     1217           
=======================================
  Hits         2881     2881           
  Misses       1247     1247           
  Partials        1        1
Flag Coverage Δ
#rn 72.02% <ø> (ø) ⬆️
#web 67.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84919e3...ecb4206. Read the comment docs.

@paranoidjk paranoidjk merged commit 2584c80 into ant-design:master Apr 26, 2017
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants