Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

直接使用Object.assign 有兼容性问题（Android5，iOS8.4） #87

Closed
pingan1927 opened this issue Aug 13, 2016 · 4 comments
Closed

直接使用Object.assign 有兼容性问题（Android5，iOS8.4） #87

pingan1927 opened this issue Aug 13, 2016 · 4 comments
Assignees
@pingan1927
Labels
bug

Comments

@pingan1927
Copy link
Contributor

直接使用Object.assign 有兼容性问题（Android5，iOS8.4）
pingan1927 added a commit that referenced this issue Aug 13, 2016
@pingan1927
fix Object.assign error #87
9df5234
@pingan1927
Copy link
Contributor Author

pingan1927 commented Aug 15, 2016 •
edited
Loading

项目代码目前通过atool-build构建，antd-mobile包的源文件中如果使用Object.assign，然而antd-mobile的组件内部的Object.assign并不会被babel自动转成es5的代码。在iOS8-,Android 5.1-，都会脚本报错，导致整个跑不起来。

所以，后续请一定使用npm模块object-assign

pingan1927 added a commit that referenced this issue Aug 15, 2016
@pingan1927
fix assign error #87
1af1eb9
@pingan1927 pingan1927 mentioned this issue Aug 15, 2016
Merged
@silentcloud
Copy link
Contributor

silentcloud commented Aug 15, 2016 •
edited
Loading

babel 转换配置少了吧？https://babeljs.io/docs/plugins/transform-object-assign/

多一个依赖引入总感觉不如直接用原生方法来的舒服

yiminghe added a commit that referenced this issue Aug 15, 2016
@yiminghe
Merge pull request #88 from ant-design/fix-assign-err
362d810 
fix assign error #87
@yiminghe
Copy link
Contributor

统一使用 object-assign

@liqi07 liqi07 assigned pingan1927 and unassigned liqi07 Aug 18, 2016
@warmhug warmhug closed this as completed Aug 19, 2016
@liqi07 liqi07 mentioned this issue Sep 1, 2016
Closed
@lock
Copy link

lock bot commented May 28, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pingan1927 pingan1927

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yiminghe @pingan1927 @silentcloud @warmhug @liqi07