Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change all props.autoFocus to instance.focus() #1243

Closed
paranoidjk opened this issue Apr 28, 2017 · 7 comments · Fixed by #1789
Closed

change all props.autoFocus to instance.focus() #1243

paranoidjk opened this issue Apr 28, 2017 · 7 comments · Fixed by #1789
Assignees
@paranoidjk
Labels
refactor
Milestone
2.0.0

Comments

@paranoidjk
Copy link
Contributor

paranoidjk commented Apr 28, 2017 •
edited
Loading

Uptdaed: https://facebook.github.io/react/docs/refs-and-the-dom.html#when-to-use-refs

ref: ant-design/ant-design#3790

https://github.com/ant-design/ant-design-mobile/search?utf8=%E2%9C%93&q=autoFocus&type=

https://github.com/ant-design/ant-design-mobile/search?q=autoFocus&type=Issues&utf8=%E2%9C%93

#1514

no messy job, if users want a input be focused automatic， use refs.foo.focus() in componentDidMount

cc @benjycui @pingan1927
@paranoidjk paranoidjk self-assigned this Apr 28, 2017
@paranoidjk paranoidjk added this to the 2.0.0 milestone Apr 28, 2017
@paranoidjk paranoidjk changed the title Change all props.autoFocus to instance.focus() change all props.autoFocus to instance.focus() Apr 29, 2017
@pingan1927
Copy link
Contributor

good idea，it's be very ok

@paranoidjk paranoidjk added the Plan label May 2, 2017
@paranoidjk
Copy link
Contributor Author

@pingan1927 有空的话可以到 2.0 的分支上开始改。 https://github.com/ant-design/ant-design-mobile/tree/feature-2.0

@pingan1927
Copy link
Contributor

嗯 这两周又开始通宵了！

@paranoidjk paranoidjk mentioned this issue Jun 27, 2017
Closed
@paranoidjk
Copy link
Contributor Author

One more reason to remove this autoFocus feature

UIWebView keyboardDisplayRequiresUserAction

When this property is set to true, the user must explicitly tap the elements in the web view to display the keyboard (or other relevant input view) for that element. When set to false, a focus event on an element causes the input view to be displayed and associated with that element automatically.
The default value for this property is true.

https://developer.apple.com/documentation/uikit/uiwebview/1617967-keyboarddisplayrequiresuseractio

WKWebView

Even do not have this api

@benjycui
Copy link
Contributor

cc @silentcloud

This was referenced Aug 22, 2017
Closed
Closed
Closed
@paranoidjk
Copy link
Contributor Author

ant-design/ant-design#3790

@paranoidjk paranoidjk mentioned this issue Sep 4, 2017
Merged
9 tasks
@ghost ghost added the In Progress label Sep 4, 2017
@paranoidjk paranoidjk reopened this Oct 16, 2017
@paranoidjk
Copy link
Contributor Author

paranoidjk commented Oct 16, 2017 •
edited by silentcloud
Loading

paranoidjk added a commit that referenced this issue Oct 19, 2017
@paranoidjk
feat(SearchBar): replace autoFocus, focused with instance.focus()
56be0fb 
#1243
@paranoidjk paranoidjk mentioned this issue Oct 19, 2017
Merged
9 tasks
paranoidjk added a commit that referenced this issue Oct 19, 2017
@paranoidjk
feat(SearchBar): replace autoFocus, focused with instance.focus() (#1963
f1db4f5 
)

* feat(SearchBar): replace autoFocus, focused with instance.focus()

#1243

* add changelog
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this issue Apr 26, 2018
@paranoidjk @lixiaoyang1992
feat(SearchBar): replace autoFocus, focused with instance.focus() (an…
0328a86 
…t-design#1963)

* feat(SearchBar): replace autoFocus, focused with instance.focus()

ant-design#1243

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paranoidjk paranoidjk

Labels
refactor
Projects
None yet
Milestone
2.0.0
6 participants
@pingan1927 @silentcloud @warmhug @benjycui @zhang740 @paranoidjk