Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(RangePicker): 更新文档 #712

Merged
merged 1 commit into from
Apr 27, 2023
Merged

docs(RangePicker): 更新文档 #712

merged 1 commit into from
Apr 27, 2023

Conversation

wyj580231
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

🎊 PR Preview 9304266 has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-712.surge.sh

🕐 Build time: 564.564s

🤖 By surge-preview

@@ -72,7 +72,7 @@ toc: 'content'
| popClassName | 弹出框类名 | string | - |
| popStyle | 弹出框样式 | string | - |
| precision | 选择精度,可选`year` `month` `day` `hour` `minute` | string | `day` |
| splitCharacter | 显示连接符 | string | ~ |
| splitCharacter | 显示连接符 | string | - |
| startPlaceholder | 开始时间提示文案 | string | 未选择 |
| prefix | 前缀 | slot | - |
| style | 样式| string | - |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码的修改很小,只是把原来的splitCharacter的默认值由~改为了-。除非在其他地方使用了这个组件并依赖于旧的默认值,否则这个修改不会引入风险。

另外,可以考虑添加一些文档或注释来描述这些属性的作用和使用方法,在维护代码时更易读和更容易理解。

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (be07e6f) 24.02% compared to head (9304266) 24.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #712   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files         158      158           
  Lines        3334     3334           
  Branches      875      875           
=======================================
  Hits          801      801           
  Misses       2202     2202           
  Partials      331      331           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jc9702507 jc9702507 merged commit ecdd210 into master Apr 27, 2023
@jc9702507
Copy link
Collaborator

#710

@github-actions github-actions bot mentioned this pull request May 9, 2023
@DiamondYuan DiamondYuan deleted the docs/RangePicker_0426 branch October 27, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants