fix: form #705
Merged
fix: form #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jc9702507
commented
Apr 24, 2023
jc9702507
commented
- 修改required, label修改行为 表单对修改了name，required，label，message，validateTrigger的行为及说明 #703
|
🎊 PR Preview af2e1d9 has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-705.surge.sh 🕐 Build time: 248.141s
🤖 By surge-preview |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| this.ref.setFormData({ | ||
| required: this.required, | ||
| }); | ||
| } | ||
| let validateTriggerList: ValidateTrigger[] | ValidateTrigger = validateTrigger || 'onChange'; | ||
| if (!Array.isArray(validateTriggerList)) { | ||
| validateTriggerList = [validateTriggerList]; |
There was a problem hiding this comment.
这段代码是一个类 Field 的部分修改，以下是我对这段代码的评价和建议：
- 在第 3 行中新增一个名为
update的参数来提高可读性是很不错的做法。 - 第 11 行，在第八个参数上的添加了一个布尔值。考虑到在创建字段时该标记值默认为假，这里修改它的值为真作用不大，可以将其去掉。
- 第 16 - 24 行是处理数据更新逻辑的关键部分。通过判断
update这一标记值是否为真，确定需不需要调用reset方法。这部分逻辑看起来没有问题，但我们还需要注意代码最后两行加入的关于validateTriggerList的赋值，因为此处会直接覆盖方法中参数validateTrigger的值，可能会影响代码的其他部分。
我的建议是：如果需要更新表单数据，则在方法 create 中加入更新数据时的相关操作，可以避免引用过多外部变量生成的机制使得更新代码难以维护。另外建议针对数据更新逻辑进行单元测试，确保代码正确性。
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
==========================================
- Coverage 24.02% 24.00% -0.03%
==========================================
Files 158 158
Lines 3334 3337 +3
Branches 873 875 +2
==========================================
Hits 801 801
- Misses 2202 2205 +3
Partials 331 331
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.