ci: add Picker、CascaderPicker test #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wyj580231
commented
Mar 30, 2023
wyj580231
commented
- Picker测试
- CascaderPicker测试
|
🎊 PR Preview a8c62dc has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-665.surge.sh 🕐 Build time: 610.996s
🤖 By surge-preview |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -125,7 +125,7 @@ function createInstance(config: Instance, props: Record<string, any>) { | |||
| didUpdate.forEach(item => item.call(instance, prevProps, prevData)); | |||
| }, | |||
| callMethod(name: string, ...args: any) { | |||
| instance.methods[name].call(instance, ...args); | |||
| return instance.methods[name].call(instance, ...args); | |||
| }, | |||
| unMount() { | |||
| didUnmount.forEach(item => item.call(instance)); | |||
There was a problem hiding this comment.
这个代码补丁包含两个函数，其中 createInstance 和 callMethod 有一个潜在的 bug。
在 createInstance 函数中，配置对象 config 包含一个名为 data 的字段。在修补程序的情况下，如果 data 是一个函数，则会调用它并将结果作为 data 的值。这是为了让每个实例都有自己的数据对象，而不是共享同一个数据对象。
但是，如果 config.data 是一个参数化函数，那么每次新的实例创建时，参数都没有更改，因此每次调用函数时获得的结果相同。这意味着不同的实例之间共享相同的数据对象，这不符合预期。应该确保每个实例都有不同的数据对象。
在 callMethod 函数中，函数返回值被丢失了。这可能会导致问题，因为调用方无法确定是否成功执行了方法。你可以尝试将函数返回 instance.methods[name].call(instance, ...args) 来解决该问题。
除此之外，代码没有明显的缺陷和有待改进的地方。
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.