Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox-group): onchange does not trigger #103

Merged
merged 3 commits into from
May 19, 2022

Conversation

Alpsli
Copy link
Member

@Alpsli Alpsli commented May 17, 2022

  • checkboxItem 的遍历数组如果先为 [],后变成非空数组就会导致 onchange 失效

@Alpsli Alpsli requested review from imsenyu and miaodongqing May 17, 2022 14:13
@miaodongqing miaodongqing merged commit 279438a into master May 19, 2022
@miaodongqing miaodongqing deleted the fix/checkboxGroup branch May 19, 2022 07:43
Alpsli added a commit that referenced this pull request May 26, 2022
* feat(image-upload): add image-upload component

* fix(minidev): update minidev version to resolve preview problem

* fix(image-upload): add preview default value for image-upload

* feat(image-upload): add css variable and change class name

* fix(demo): remove useless formValidate page

* feat(video-upload): add videoUpload compoents

* feat(file-upload): add fileUpload compoents

* feat(file-upload): add toast lock to avoid fastclick

* feat(file-upload): add css variable

* feat(file-upload): add onPreviewFail callback

* feat(upload): add markdown

* feat(file-upload): add maxCount props

* feat(uploader): fix lint

* feat(video-upload): add maxCount props

* feat(video-upload): markdown add maxCount props

* feat(uploader): add promisify declare namespace

* feat(doc): update appCdnBaseUrl

* feat(image-upload): failed state style changes and commit success logic adjustments

* fix(Icon): fix color style used in plugin (#93)

Co-authored-by: wyj <[email protected]>

* fix(vTabs): fix click bottom tap jump to the tap before (#95)

* fix(vTabs): fix click bottom tap jump to the tap before

* fix(VTabs): fix active style of the before tab border

Co-authored-by: 彧衡 <[email protected]>

* fix(CheckboxGroup): remove default value prop (#96)

Co-authored-by: wyj <[email protected]>

* chore(Picker): this.dataList sync  with props.data (#94)

Co-authored-by: 陌缓 <[email protected]>

* feat(doc): use google analytics (#100)

Co-authored-by: 陌缓 <[email protected]>

* feat(Tips): 单行文本时关闭按钮垂直居中 (#98)

* feat(Tips): 单行文本时关闭按钮垂直居中

* feat(Tips): getTextType避免重复触发didUpdate

Co-authored-by: wyj <[email protected]>

* fix(checkbox-group): onchange does not trigger (#103)

* fix(checkbox-group): checkboxItem dynamic rendering onchange does not trigger

* fix(checkbox-group): checkboxItem dynamic rendering onchange does not trigger

* fix(checkbox-group): adjust md

Co-authored-by: 彧衡 <[email protected]>

* chore(dumi): fix conflict babal.config.js (#109)

Co-authored-by: 陌缓 <[email protected]>

* Chore/picker (#108)

* chore(Picker): this.dataList sync  with props.data

* chore(Picker): refactor picker

Co-authored-by: 陌缓 <[email protected]>

* Chore/switch (#110)

* chore(Switch): refactor Switch

* chore(Switch): restore  compiles.js

Co-authored-by: 陌缓 <[email protected]>

* Chore/tab (#111)

* chore(Tab): update margin to padding

* chore(Tab): restore tab.less

Co-authored-by: 陌缓 <[email protected]>

Co-authored-by: 彧衡 <[email protected]>
Co-authored-by: 陌缓 <[email protected]>
Co-authored-by: wyj580231 <[email protected]>
Co-authored-by: wyj <[email protected]>
Co-authored-by: miaodongqing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants