Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license in galaxyui package.json #900

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

akaRem
Copy link
Contributor

@akaRem akaRem commented Jul 15, 2018

galaxyui/package.json has MIT license, but all banners in this repo
state that license is Apache-2.

This patch fixes license field to be Apache-2.

galaxyui/package.json has MIT license, but all banners in this repo
state that license is Apache-2.

This patch fixes license field to be Apache-2.

Signed-off-by: Ivan Remizov <[email protected]>
@chouseknecht chouseknecht requested a review from newswangerd July 15, 2018 16:06
@cutwater
Copy link
Collaborator

I think we're using Apache 2.0 license for all source code. In that case Apache 2.0 headers should be added to all significant parts of UI code.

@akaRem
Copy link
Contributor Author

akaRem commented Jul 16, 2018

@cutwater do you want me to add banners to all galaxyui files?

@newswangerd
Copy link
Member

I'm okay with adding the license to the banner as long as we can find a way to do it automatically and as long as the comments get removed during the compilation process so that we aren't wasting bandwidth and load time by serving up tons of redundant comments.

@cutwater cutwater merged commit 546ccf7 into ansible:devel Jul 16, 2018
@akaRem akaRem deleted the fix/galaxyui-license branch July 16, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants