add link back to Galaxy from docs #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@newswangerd can you comment on the original change and its intention? |
I think the original idea behind #1374 was that it was confusing for users that clicking on "Documentation" took them to galaxy. I think the proposed changes here are probably the right way to fix this problem because it allows users to be able to go back to the main site without confusing them with the Documenation text in the logo. |
newswangerd
approved these changes
Jun 10, 2019
newswangerd
pushed a commit
to newswangerd/galaxy
that referenced
this pull request
Jun 11, 2019
(cherry picked from commit 9507139)
newswangerd
added a commit
that referenced
this pull request
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1374 removed the link that allows a user to go from Galaxy docs back to the Galaxy itself. This PR:
BEFORE:
AFTER:
Note that line 154 keeps the documentation (docs) link within the teal navigation window so the original issue is still fixed with this patch.