Fix collection detail breaking when no description is set. #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironfroggy
reviewed
Jun 10, 2019
| @@ -137,7 +137,8 @@ export class ContentHeaderComponent implements OnInit { | |||
| iconClass: 'pficon-repository', | |||
| tooltip: 'Collection', | |||
| name: this.collection.name, | |||
| description: this.collection.latest_version.metadata.description, | |||
| description: | |||
| this.collection.latest_version.metadata.description || '', | |||
There was a problem hiding this comment.
Is this the right fix, or should it have been an import error for the metadata to exclude a description in the first place? I did not think it was supposed to be optional.
There was a problem hiding this comment.
I looked into this and the description isn't required in the spec, so the importer is currently doing the right thing by ignoring it.
ironfroggy
approved these changes
Jun 10, 2019
newswangerd
added a commit
to newswangerd/galaxy
that referenced
this pull request
Jun 10, 2019
) (cherry picked from commit 65f6692)
newswangerd
added a commit
that referenced
this pull request
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1905