Fix DoesNotExist exception in content serializer #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `QuerySet.latest` method raises `DoesNotExist` exception if query returns empty set. This patch fixes the issue and returns empty list for `task_messages` field if no import task exists for a content's repository. Additionally it replaces `id` attribute access through a related object with direct foreign key `repository_id`. It also replaces import task sorting by `id` with sorting by `created` date as it's better way of determining latest record. (cherry picked from commit 410c81c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QuerySet.latestmethod raisesDoesNotExistexception ifquery returns empty set. This patch fixes the issue and returns
empty list for
task_messagesfield if no import task existsfor a content's repository.
Additionally it replaces
idattribute access through a related objectwith direct foreign key
repository_id.It also replaces import task sorting by
idwith sorting bycreateddate as it's better way of determining latest record.
Backport: #1364
(cherry picked from commit 410c81c)