Improve Galaxy logging #1351
Merged
Improve Galaxy logging #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 379d1a9)
(cherry picked from commit ec34bd3)
(cherry picked from commit bb9cf03)
* Logging configuration at the bottom of settings file due to its size. * Remove duplicated filter `request_id` from production settings. * Fix typo in `django.request` handler. (cherry picked from commit b386b03)
Relative module names are non informative. Since Galaxy uses loggers based on module name, logger name reflects module and gives fully qualified name. (cherry picked from commit a06a955)
* Explicit `django.db` logger is not needed as it's handled by 'django' logger. * The logger `django.request` duplicates django's builtin configuration [1]. By default django sends all `ERRROR` and `CRITICAL` messages to the `AdminEmailHandle` in `DEBUG=False` mode. * Remove explicit `propagate=True`, since child loggers propagate log messages to parent loggers by default. * Remove allauth debug logger. (cherry picked from commit 0227513)
* Aggregate multiple specific logger configurations into single global `galaxy` configuration. * Set minimal log level `WARNING` for production environment. Implications: Due to project structure and celery architecture all worker messages have to be handled by `galaxy` worker and should not be propagated to root logger, that is patched by `celery`. As a result celery log message format is sligtly different from the galaxy one. To be fixed in future patches. (cherry picked from commit e20539f)
* Disable autoreload. * Set minimal log level to `WARNING`. (cherry picked from commit 3869d71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: #1342