Add better error message for wfjt create 403 #15309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
reviewed
Jun 27, 2024
AlanCoding
reviewed
Jun 27, 2024
TheRealHaoLiu
force-pushed
the
better-error-message-on-wfjt-create-403
branch
3 times, most recently
from
7ee07dc to
c17dc82
Compare
AlanCoding
reviewed
Jun 28, 2024
TheRealHaoLiu
force-pushed
the
better-error-message-on-wfjt-create-403
branch
from
c17dc82 to
c1ff210
Compare
TheRealHaoLiu
force-pushed
the
better-error-message-on-wfjt-create-403
branch
from
c1ff210 to
0078f9e
Compare
AlanCoding
approved these changes
Jun 28, 2024
AlanCoding
reviewed
Jun 28, 2024
| return False | ||
|
|
||
| if not self.check_related('execution_environment', ExecutionEnvironment, data, role_field='read_role'): | ||
| self.messages['execution_environment'] = [_('You do not have read_role to the execution environment')] |
There was a problem hiding this comment.
Wait, this is confusing. There actually isn't a read_role for EEs.
They don't have permission to view the EE.
|
Unit/Functional test for this would also be nice. |
AlanCoding
reviewed
Jul 1, 2024
| wfjt.admin_role.members.add(rando) | ||
| access = WorkflowJobTemplateAccess(rando, save_messages=True) | ||
| assert not access.can_add({'name': 'without org'}) | ||
| assert 'An organization is required to create a workflow job template for normal user' in access.messages['organization'] |
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
More detail around when non super admin user trying to create WFJT without an org
JIRA: https://issues.redhat.com/browse/AAP-25635
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION