win_domain_user: do not hide error on failures #58357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ShachafGoldstein @if-meaton @jhawkesworth @nitzmahone |
ansibot
added
affects_2.9
jillr
removed
the
needs_triage
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Jul 1, 2019
* win_domain_user: do not hide error on failures * Was a bit too overzealous in the removal * Remove uneeded sanity ignore rule (cherry picked from commit c260721)
|
Backport PR to stable-2.8 #58611. |
abadger
pushed a commit
that referenced
this pull request
Jul 16, 2019
* win_domain_user: do not hide error on failures * Was a bit too overzealous in the removal * Remove uneeded sanity ignore rule (cherry picked from commit c260721)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The try/catch blocks in each operation are hiding the error that is occurring making it hard to debug failures. Since Ansible 2.8 we will record unhandle exceptions a lot more cleanly and also show the stacktrace so we can pinpoint where something actually failed.
Related https://groups.google.com/forum/#!topic/ansible-project/0SsiThLopNI.
ISSUE TYPE
COMPONENT NAME
win_domain_user