facts: fix SPARC cpu count on linux #30792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On sparc64, /proc/cpuinfo has no usual 'model name', 'Processor', 'vendor_id', 'Vendor', as a result "ansible_processor_vcpus" is always 1. Add check element "ncpus active" to fix the issue. Backport from e93ecac (ansible#30261)
|
@zorun Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibot
added
affects_2.5
alikins
added
affects_2.3
ansibot
added
bugfix_pull_request
stale_ci
ansibot
added
the
new_contributor
ansibot
removed
the
new_contributor
|
The change looks good but I don't have a SPARC cpu to verify that it works. |
|
@jimi-c bring this in for 2.3 backport? |
ansibot
added
the
new_contributor
ansibot
added
bug
|
Ansible 2.3 has reached end-of-life and is no longer supported. See release and maintenance status for additional details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
On sparc64, /proc/cpuinfo has no usual 'model name', 'Processor', 'vendor_id', 'Vendor',
as a result "ansible_processor_vcpus" is always 1.
Add check element "ncpus active" to fix the issue.
Backport from e93ecac (#30261)
ISSUE TYPE
COMPONENT NAME
facts
ADDITIONAL INFORMATION
This is not a straight cherry-pick from e93ecac (#30261) because some code has been moved around. But the actual change is exactly the same.