Fix fapolicyd required check #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ccravens Thank you as always for your feedback. Improvements are always welcome. Many thanks as always uk-bolly |
|
hi @ccravens I will incorporate this to the new release, which i hope will be out next week. Thank you again uk-bolly |
uk-bolly
added a commit
that referenced
this pull request
Jan 27, 2023
Signed-off-by: Mark Bolwell <[email protected]>
Merged
|
Hi @ccravens This should now be included, and i have just added another update to this in the latest PR. Please let me know if this resolved the issue. many thanks uk-bolly |
|
@uk-bolly thank you! I'll try and remember to put that signature in the comment next time I contribute. Thank you for continuing to support this project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
fapolicyd genrules will fail if it sees the old
/etc/fapolicyd/fapolicyd.ruleswith updated versions of fapolicyd. There is a rule that checks that stat for the existance of the new/etc/fapolicyd/rules.d/folder, however the results of this were not being used in the subsequent rules. This appears to have been an accidental omission, and this just resolves that.How has this been tested?:
Tested against CentOS 8 Stream Minimal Install and worked well