Fix some favicon issues #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conversion done with ImageMagick: convert -background none Ansible-Mark-RGB_Black.svg -resize 180x180 Ansible-Mark-RGB_Black.png convert -background none Ansible-Mark-RGB_White.svg -resize 180x180 Ansible-Mark-RGB_White.png
|
Ok, I also resolved the last issue: that the icons weren't shown on Safari. The problem is that Safari does not support SVGs for icons :-( So if we use SVGs, Safari will not display them. That's why I converted the SVGs to PNGs. I included instructions on how to do the conversion with ImageMagick in the commit message; where should I properly document it? In the README, or somewhere else? |
|
Thanks for looking into this. |
|
Actually, we have original logos here https://www.ansible.com/logos |
This reverts commit efe597a.
This reverts commit 03303c2.
The small versions of the PNGs are created from the large official logos downloaded from
https://www.ansible.com/logos
with ImageMagick as follows:
convert Ansible-Mark-Large-RGB-Black.png -resize 180x180 Ansible-Mark-RGB_Black.png
convert Ansible-Mark-Large-RGB-White.png -resize 180x180 Ansible-Mark-RGB_White.png
|
Thanks, I used the images from there and added instructions to the README how they are obtained and how I modified them (adjusting the SVG bounding box; rescaling the PNG versions). |
|
CC @webknjaz |
ssbarnea
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #ansible-community.