Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💖 looking for molecule ec2 driver maintainers #39

Closed
ssbarnea opened this issue Mar 20, 2020 · 17 comments
Closed

💖 looking for molecule ec2 driver maintainers #39

ssbarnea opened this issue Mar 20, 2020 · 17 comments
Labels
ec2 Amazon EC2

Comments

@ssbarnea
Copy link
Member

I am unable to maintain this driver as I am not using it, so I am looking for maintainers.

I can keep providing support for CI and integration with molecule itself but not around driver specifics.

@ssbarnea ssbarnea pinned this issue Mar 20, 2020
@Shaps
Copy link

Shaps commented Mar 20, 2020

I’m going to need this driver soon, so happy to work on it as best as I can!

@ghost
Copy link

ghost commented Mar 21, 2020

i can also work.

@ghost
Copy link

ghost commented Mar 21, 2020

we are already using it very heavily, so will be happy to contribute.

@jgoldschrafe
Copy link

Count me in as well.

@khuedoan
Copy link

khuedoan commented Jun 1, 2020

Count me in 😄

@ssbarnea ssbarnea changed the title 💖 looking for ec2 maintainers 💖 looking for molecule ec2 driver maintainers Sep 7, 2020
@ssbarnea
Copy link
Member Author

I am still looking for people, please ping me on irc if you want to take it under your wing.

@tbugfinder
Copy link

Made it any of the volunteers into the maintainers?

@ssbarnea
Copy link
Member Author

Invitation is still open and the fact the the project has 5 open PRs is not very good.

I can help only when pull-requests are passing CI and anyone can contact me (zbr) on freenode #ansible-lint channel.

Shortly, the invitation is still open.

@ssbarnea
Copy link
Member Author

@gundalow Please restore my rights, so I can give others triage and later write access.

@luupux
Copy link

luupux commented Feb 24, 2021

@ssbarnea sorry I wroted using wrong accont (infra-agilelab) so my offer still valid but on my personal account @luupux

@ssbarnea
Copy link
Member Author

I invited everyone involved in this thread to be a collaborator, initially with triage but I will boost it as soon I get some extra confirmation.

@luupux
Copy link

luupux commented Feb 25, 2021

sorry to bother with boring question but in this case what it's mean collaboration with triage ?

@ssbarnea
Copy link
Member Author

ssbarnea commented Feb 25, 2021

Mainly it means you can open/close/edit issues. Once you do few reviews I will enable write access, which means ability to merge.

There is only one older pull-request open which seems abandoned by OP, still, take a look at it and see if you can extract something useful out of it before we close it.

I guess that once done, you will want me to help with a new release. Ping me and I will tag a new one if one of you can confirm that master code works fine with current release of molecule/ansible.

@jgoldschrafe
Copy link

Hey @ssbarnea, sorry to bother, but I completely neglected to ever ack the invite, but could have sworn I did. Would you mind sending another one?

@ssbarnea
Copy link
Member Author

ssbarnea commented Dec 1, 2021

@jgoldschrafe Somehow I missed the reply, still interested? I sent the invite again.

I observed that this repo lacked active maintenance for a very long time and I will have to drop it from the list of maintained plugins if nobody steps in to keep at least the CI green and compatible with newer versions of molecule.

@ssbarnea
Copy link
Member Author

Anyone still interested in helping with maintenance of this plugin? I need some some help with review from people using this in production, especially as some proposed PRs have the potential of introducing regressions.

@beargiles
Copy link

I hope to submit several PRs soon and could probably help with the maintenance afterwards. (It will give you a chance to evaluate my skills, etc.) We're just starting to use molecule + ec2 at work so I wouldn't say this is a 'production' work - but I am using it to develop and maintain both my ansible scripts that manage dev and qa resources.

@ssbarnea ssbarnea added the ec2 Amazon EC2 label Jan 5, 2023
@ssbarnea ssbarnea transferred this issue from ansible-community/molecule-ec2 Jan 5, 2023
apatard added a commit to apatard/molecule-plugins that referenced this issue Apr 27, 2023
…raw args

Since molecule ansible/molecule#3887, the
jinja is now autoescaping, which leads to things like:

virtualbox.customize [&ansible-community#39;modifyvm&ansible-community#39;, :id, &ansible-community#39;--natdnshostresolver1&ansible-community#39;, &ansible-community#39;on&ansible-community#39;]

in the Vagrantfile.

Add some "safe" filters to solve this.

Signed-off-by: Arnaud Patard <[email protected]>
ssbarnea pushed a commit that referenced this issue Apr 27, 2023
src/molecule_plugins/vagrant/modules/vagrant.py: Add safe filter for raw args

Since molecule ansible/molecule#3887, the
jinja is now autoescaping, which leads to things like:

virtualbox.customize [&#39;modifyvm&#39;, :id, &#39;--natdnshostresolver1&#39;, &#39;on&#39;]

in the Vagrantfile.

Add some "safe" filters to solve this.

Signed-off-by: Arnaud Patard <[email protected]>
@ansible-community ansible-community locked and limited conversation to collaborators Nov 14, 2023
@zhan9san zhan9san converted this issue into discussion #202 Nov 14, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
ec2 Amazon EC2
Projects
None yet
Development

No branches or pull requests

7 participants