Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make docs processing more robust #32

Merged
merged 6 commits into from
Sep 7, 2022
Merged

Make docs processing more robust #32

merged 6 commits into from
Sep 7, 2022

Conversation

felixfontein
Copy link
Collaborator

Currently the devel docs build fails with https://pastebin.com/K1u95BXx.

briantist
briantist approved these changes Sep 3, 2022
View reviewed changes
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a non-blocking request for a comment on the confusing ??? value

src/antsibull_docs/cli/doc_commands/stable.py Outdated Show resolved Hide resolved
@felixfontein
Copy link
Collaborator Author

Hmm, something isn't right yet. Need to look at this some more.

@felixfontein
Copy link
Collaborator Author

I'm now happy with the actual docsite output.

(This project definitely needs better tests - probably we need to include a test collection and the expected RST output for it.)

@felixfontein felixfontein merged commit ff9e558 into ansible-community:main Sep 7, 2022
@felixfontein felixfontein deleted the robust branch September 7, 2022 19:27
@felixfontein
Copy link
Collaborator Author

@briantist thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @briantist