Collection docs linting: validate references to other plugins/modules/roles #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
other-collections
branch
3 times, most recently
from
344d823 to
89a7ae8
Compare
felixfontein
force-pushed
the
other-collections
branch
from
89a7ae8 to
c6c6898
Compare
|
This now contains all the features I want (for this PR :) ). |
felixfontein
changed the title
felixfontein
commented
Jun 10, 2023
briantist
reviewed
Jun 10, 2023
felixfontein
force-pushed
the
other-collections
branch
from
c6c6898 to
7c7166b
Compare
briantist
approved these changes
Jun 10, 2023
|
@briantist thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
O()andRV()are only validated for references to the same plugin/module/role. This PR extends this functionality to also validate references to other plugins/modules/roles in the same collection - including checking whether the names supplied toM()andP()make sense -, and optionally also allows to check references to dependent collections.(I plan to extend this to check all installed collections as well, maybe already in this PR before it's ready, or in a follow-up PR...)Currently includes #155 and #156, will rebase once these have been merged.