Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always lint before releasing #67

Merged

Conversation

felixfontein
Copy link
Collaborator

Fixes #65.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #67 (eb3e967) into main (ec7f6ce) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   88.96%   88.98%   +0.02%     
==========================================
  Files          16       16              
  Lines        2021     2025       +4     
  Branches      505      506       +1     
==========================================
+ Hits         1798     1802       +4     
- Misses        138      141       +3     
+ Partials       85       82       -3     
Impacted Files Coverage Δ
antsibull_changelog/cli.py 74.91% <100.00%> (+0.36%) ⬆️
antsibull_changelog/yaml.py 84.21% <0.00%> (-15.79%) ⬇️
antsibull_changelog/fragment.py 92.64% <0.00%> (+2.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7f6ce...eb3e967. Read the comment docs.

@dmsimard
Copy link

dmsimard commented Nov 4, 2021

Thanks @felixfontein ! Do you think this could have adverse effects on release changelogs that have already been generated without first being linted ?

@felixfontein
Copy link
Collaborator Author

I think the main downside is that releasing will be a bit slower (well, most time is still used for collection module/plugin version_added fields), and that it's no longer possible to insert invalid fragments into a release this way. Which I think is a good thing.

@felixfontein
Copy link
Collaborator Author

(Also this PR only lints the changelog fragments that haven't been integrated into the changelog yet, and will be integrated by the release command.)

@felixfontein felixfontein merged commit 4ebec26 into ansible-community:main Nov 13, 2021
@felixfontein felixfontein deleted the linting-on-release branch November 13, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release_summary inside a fragment can be a list of strings but should be enforced as a single string
2 participants