Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build system to hatchling and add noxfile #109

Merged
merged 15 commits into from
Mar 29, 2023

Conversation

felixfontein
Copy link
Collaborator

No description provided.

@felixfontein felixfontein requested a review from gotmax23 March 28, 2023 20:30
@gotmax23 gotmax23 changed the title [WIP] Switch build system to hatchling [WIP] Switch build system to hatchling and add noxfile Mar 28, 2023
@gotmax23
Copy link
Contributor

I had some work on this locally that I applied on top of your PR: https://github.com/gotmax23/antsibull-changelog/commits/build-system. Feel free to pull it in and make any changes you see fit or I can push it to your fork myself.

@gotmax23
Copy link
Contributor

Also, I'm confused as to why there's a .mypy and mypy.ini. We might want to consider switching to the pyproject.toml based mypy configuration in a separate PR.

types-toml = "*"
[project.optional-dependencies]
test = [
"mock",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: we should get rid of the mock dependency and use unittest.mock instead. The mock package is a backport of stdlib code that's not necessary for newer pythons.

felixfontein and others added 6 commits March 29, 2023 07:49
Move the antsibull-changelog lint integration tests into the noxfile so
they can be run locally and in CI.
This configuration makes `nox -e coverage` properly aggregate results
across Python versions when running without editable mode in CI.
This is based on the text from antsibull and antsibull-docs-parser.
Use the extra instead of manually depending on coverage in the three
targets that use it. This makes it easier to pin coverage if we need to.
@felixfontein
Copy link
Collaborator Author

Also, I'm confused as to why there's a .mypy and mypy.ini. We might want to consider switching to the pyproject.toml based mypy configuration in a separate PR.

There should have only been .mypy.ini. I agree on consolidating to use pyproject.toml for all the other tools (which support it), having all these random small config files around is annoying :)

@felixfontein felixfontein changed the title [WIP] Switch build system to hatchling and add noxfile Switch build system to hatchling and add noxfile Mar 29, 2023
@felixfontein felixfontein marked this pull request as ready for review March 29, 2023 06:37
@felixfontein felixfontein requested a review from gotmax23 March 29, 2023 06:37
Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two suggestions, but this looks good to me. Thanks for working on it!

.github/workflows/nox.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit 55515d9 into ansible-community:main Mar 29, 2023
@felixfontein felixfontein deleted the build-system branch March 29, 2023 16:48
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks a lot for preparing this and reviewing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants