-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch build system to hatchling and add noxfile #109
Switch build system to hatchling and add noxfile #109
Conversation
I had some work on this locally that I applied on top of your PR: https://github.com/gotmax23/antsibull-changelog/commits/build-system. Feel free to pull it in and make any changes you see fit or I can push it to your fork myself. |
Also, I'm confused as to why there's a .mypy and mypy.ini. We might want to consider switching to the pyproject.toml based mypy configuration in a separate PR. |
types-toml = "*" | ||
[project.optional-dependencies] | ||
test = [ | ||
"mock", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: we should get rid of the mock
dependency and use unittest.mock
instead. The mock
package is a backport of stdlib code that's not necessary for newer pythons.
Move the antsibull-changelog lint integration tests into the noxfile so they can be run locally and in CI.
This configuration makes `nox -e coverage` properly aggregate results across Python versions when running without editable mode in CI.
This is based on the text from antsibull and antsibull-docs-parser.
Use the extra instead of manually depending on coverage in the three targets that use it. This makes it easier to pin coverage if we need to.
There should have only been |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two suggestions, but this looks good to me. Thanks for working on it!
Co-authored-by: Maxwell G <[email protected]>
Co-authored-by: Maxwell G <[email protected]>
@gotmax23 thanks a lot for preparing this and reviewing :) |
No description provided.