Avoid raising raw 'Exception'

changelogs/fragments/103-exceptions.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - "Use more specific exceptions than ``Exception`` for some cases in internal code (https://github.com/ansible-community/antsibull-changelog/pull/103)."

src/antsibull_changelog/cli.py

@@ -363,8 +363,7 @@ def _get_refresh_config(args: Any,
             elif part == 'fragments-without-archives':
                 refresh_fragments = 'without-archives'
             else:
-                # pylint:disable-next=broad-exception-raised
-                raise Exception(
+                raise ValueError(
                     'The config value always_refresh contains an invalid value "{0}"'.format(
                         part))
     return refresh_plugins, refresh_fragments

src/antsibull_changelog/config.py

@@ -205,8 +205,7 @@ def _load_galaxy_yaml(self, needed_var: str,
         if self.galaxy_yaml_loaded:
             return
         if not self.paths.is_collection:
-            # pylint:disable-next=broad-exception-raised
-            raise Exception('Internal error: cannot get collection details for non-collection')
+            raise RuntimeError('Internal error: cannot get collection details for non-collection')
 
         if what_for is None:
             what_for = 'load field "{0}"'.format(needed_var)

src/antsibull_changelog/plugins.py

@@ -433,8 +433,7 @@ def _get_ansible_core_version(paths: PathsConfig) -> packaging.version.Version:
         match = re.match(regex, output)
         if match:
             return packaging.version.Version(match.group(1))
-    # pylint:disable-next=broad-exception-raised
-    raise Exception(
+    raise RuntimeError(
         f'Cannot extract ansible-core version from ansible-doc --version output:\n{output}')
 
 

src/antsibull_changelog/toml.py

@@ -51,5 +51,4 @@ def load_toml(path: str) -> Any:
     if HAS_TOML:
         with open(path, 'r', encoding='utf-8') as f:
             return toml.loads(f.read())
-    # pylint:disable-next=broad-exception-raised
-    raise Exception('Need tomllib/tomli/toml library to read TOML file')
+    raise RuntimeError('Need tomllib/tomli/toml library to read TOML file')

tests/functional/test_changelog_basic_other.py

@@ -13,7 +13,6 @@
 import os
 
 import mock
-
 from fixtures import other_changelog  # noqa: F401; pylint: disable=unused-variable
 from fixtures import create_plugin