completed unit tests

Signed-off-by: Pranav Bhatt <[email protected]>
ansible-collections · Mar 15, 2022 · 30647fa · 30647fa
1 parent c46b2ea
commit 30647fa
Show file tree

Hide file tree

Showing 7 changed files with 401 additions and 48 deletions.
diff --git a/...s/module_utils/network/junos/argspec/security_policies_global/security_policies_global.py b/...s/module_utils/network/junos/argspec/security_policies_global/security_policies_global.py
@@ -91,7 +91,6 @@ def __init__(self, **kwargs):
                                 "size": {"type": "str"},
                                 "world_readable": {"type": "bool"},
                             },
-                            "required": True,
                             "type": "dict",
                         },
                         "flag": {

diff --git a/...ns/module_utils/network/junos/config/security_policies_global/security_policies_global.py b/...ns/module_utils/network/junos/config/security_policies_global/security_policies_global.py
@@ -262,7 +262,7 @@ def _state_merged(self, want, _have):
                 log_node = build_child_xml_node(pre_id_node, "log")
                 if "session_close" in pre_id["log"]:
                     build_child_xml_node(log_node, "session-close")
-                elif "session_init" in pre_id["log"]:
+                if "session_init" in pre_id["log"]:
                     build_child_xml_node(log_node, "session-init")
 
             if "session_timeout" in pre_id:
@@ -348,9 +348,7 @@ def _state_merged(self, want, _have):
                     flag_node = build_child_xml_node(traceoptions_node, "flag")
                     build_child_xml_node(flag_node, "name", "lookup")
                 elif traceoptions["flag"] == "routing-socket":
-                    build_child_xml_node(
-                        traceoptions_node, "flag", "routing-socket"
-                    )
+                    flag_node = build_child_xml_node(traceoptions_node, "flag")
                     build_child_xml_node(flag_node, "name", "routing-socket")
                 elif traceoptions["flag"] == "rules":
                     flag_node = build_child_xml_node(traceoptions_node, "flag")

diff --git a/...ins/module_utils/network/junos/facts/security_policies_global/security_policies_global.py b/...ins/module_utils/network/junos/facts/security_policies_global/security_policies_global.py
@@ -10,7 +10,6 @@
 based on the configuration.
 """
 from __future__ import absolute_import, division, print_function
-from inspect import trace
 
 __metaclass__ = type
 

diff --git a/plugins/modules/junos_security_policies_global.py b/plugins/modules/junos_security_policies_global.py
@@ -145,7 +145,6 @@
           file:
             description: A dictionary to configure the trace file options
             type: dict
-            required: true
             suboptions:
               files:
                 description:

diff --git a/tests/integration/targets/junos_security_policies_global/vars/main.yaml b/tests/integration/targets/junos_security_policies_global/vars/main.yaml
@@ -62,4 +62,4 @@ replaced:
         files: 4
         match: /[A-Z]*/gm
         size: 10k
-      flag: all
+      flag: all
diff --git a/tests/unit/modules/network/junos/fixtures/junos_security_policies_global_config.cfg b/tests/unit/modules/network/junos/fixtures/junos_security_policies_global_config.cfg
@@ -12,7 +12,7 @@
                   <match>/[A-Z]*/gm</match>
                </file>
                <flag>
-                  <name>all</name>
+                  <name>lookup</name>
                </flag>
             </traceoptions>
             <default-policy>