Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for #664 and #678 for 1.4.1 #732

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Fixes for #664 and #678 for 1.4.1 #732

merged 3 commits into from
Apr 14, 2023

Conversation

rexemin
Copy link
Collaborator

@rexemin rexemin commented Apr 11, 2023

SUMMARY

Fixes for both #664 and #678, but now for release 1.4.1. The same code found in PR #725.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zos_copy

@rexemin rexemin marked this pull request as ready for review April 11, 2023 18:41
@rexemin rexemin requested review from ketankelkar and richp405 April 11, 2023 18:41
ddimatos

This comment was marked as duplicate.

Sign in to view

ddimatos
ddimatos requested changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@ddimatos ddimatos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting on pipeline to complete.

@ddimatos ddimatos added the In Progress This issue is under review by a team member. label Apr 14, 2023
@ddimatos
Copy link
Collaborator

Pipeline /view/AC/job/zosAnsible/1651/
image

ddimatos
ddimatos approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@ddimatos ddimatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @rexemin

richp405
richp405 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay to me

@ddimatos ddimatos merged commit 9b886a3 into support/v1.4.1 Apr 14, 2023
@ddimatos ddimatos deleted the bugfix/664_678/zos_copy-encoding-1.4.1 branch April 15, 2023 22:29
@rexemin rexemin linked an issue Apr 18, 2023 that may be closed by this pull request
[Bug] [zos_copy] Sometimes the record length computation throws an encoding error #664
Closed
@rexemin rexemin removed the In Progress This issue is under review by a team member. label Apr 18, 2023
@rexemin rexemin linked an issue Apr 18, 2023 that may be closed by this pull request
[Bug] [zos_copy] File normalizing is making assumptions that could pose encoding mixup #678
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddimatos ddimatos ddimatos approved these changes

@richp405 richp405 richp405 approved these changes

@ketankelkar ketankelkar Awaiting requested review from ketankelkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rexemin @ddimatos @richp405