Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects zos_data_set default record format FB breaking VSAM #647

Conversation

ddimatos
Copy link
Collaborator

@ddimatos ddimatos commented Feb 21, 2023

SUMMARY

This addresses issues #638 and #646 such that when the default value for record format FB was set it was was also set for VSAM and this would break VSAM data set creation. It did not make sense to not have a default so it was added back after going through the changes enforced by ansible 2.14. This code adds the correcting behavior.

BGYSC1402E Dynalloc ' 'Failure. Error Code: ' '0x9700, Information Code: '"0x00\\n
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

See git issue #646 for more detals

ADDITIONAL INFORMATION

@ddimatos ddimatos self-assigned this Feb 21, 2023
@ddimatos ddimatos added Bug Something isn't working as designed. Enabler Enabler task and removed Bug Something isn't working as designed. labels Feb 21, 2023
@ddimatos
Copy link
Collaborator Author

Passed locally:

ddimatos:[ ~/git/github/ibm_zos_core ]make test host=xxxxxx python=3.9 zoau=1.2.2 name=tests/functional/modules/test_zos_data_set_func.py debug=true

result: =================================================================== 62 passed in 696.66s (0:11:36) ===================================================================

@ddimatos
Copy link
Collaborator Author

Although this solution does work , longer term enhancing our better arg parsers mutual exclusive capabilities such that it can be instructed when what is seeing is a result of a default value and know when it's permitted and when it's not, eg an exemption list also be provided. Such work needs appropriate planning because all modules use the parser

@ddimatos ddimatos marked this pull request as ready for review February 21, 2023 21:51
@ddimatos
Copy link
Collaborator Author

image

Log suffix `/view/AC/job/zosAnsible/1481/`

@ddimatos ddimatos requested a review from ketankelkar February 21, 2023 21:52
Copy link
Collaborator

@ketankelkar ketankelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ddimatos ddimatos merged commit 27f8d35 into release-v1.5.0-beta.1 Feb 21, 2023
@ddimatos ddimatos deleted the update/zos_data_set/correcting-default-rec-format-with-fb branch February 21, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enabler Enabler task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants