Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [zos_copy] Fix for data set type error #566

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

rexemin
Copy link
Collaborator

@rexemin rexemin commented Nov 15, 2022

SUMMARY

Fixes #543.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zos_copy

ADDITIONAL INFORMATION

This issue is probably caused by a bug in ZOAU where volumes with system symbols are not properly handled (the original data set reported in the issue was SYS1.SAMPLIB, which is located in a volume like that), so dls is unable to get the data set's information. This is a bugfix intended for v1.4.0, where we still won't be supporting ZOAU 1.2.x officially. In v1.5.0, the dependency on a newer ZOAU should make this bugfix unnecesary, as the bug in dls is already fixed there.
The bugfix is just a call to LISTDS through IKJEFT01 when dls doesn't return the data set information.

Copy link
Collaborator

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to see what you and the customer described.

hosts = ansible_zos_module
# The volume for this dataset should use a system symbol.
# This dataset and member should be available on any z/OS system.
src = "SYS1.SAMPLIB(IZUPRM00)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this on one of our EC's, and volume is '*****'. I will assume this means it can't process the volume name. Nice!

@fernandofloresg
Copy link
Collaborator

Nice catch. Thanks for using mvs_cmd to invoke the program and adding a test case.

@rexemin
Copy link
Collaborator Author

rexemin commented Nov 16, 2022

And here is the result for the pipeline. Thanks again @fernandofloresg for reminding me that modifying module_utils/data_set.py will trigger virtually all tests.

Screen Shot 2022-11-16 at 13 09 33
Screen Shot 2022-11-16 at 13 09 47

@fernandofloresg fernandofloresg merged commit 53ceca9 into support/1.4.0 Nov 17, 2022
@ddimatos ddimatos deleted the bugfix/543/zos_copy_system_symbol branch April 15, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] zos_copy PDS(xxx) to PDS(xxx) fails at 1.4.0-beta.2
3 participants