Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - corrects the dd_name used in jobs.py #507

Merged

Conversation

ddimatos
Copy link
Collaborator

@ddimatos ddimatos commented Oct 5, 2022

SUMMARY

Fixed a typo in module_utils/job.py:
module_utils/job.py line 59 in 1.3.4 code reads:
dd_name = parsed_args.get("ddname") or ""

To
dd_name = parsed_args.get("dd_name") or ""
Fixes #329 on support 1.3.x branch

This was cherry-picked from a prior release to forward fix the 1.4.0-beta.2 release.
These are the commits cherry-picked:
31f8eb3
dd7b3f5

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ddimatos ddimatos added the Bug Something isn't working as designed. label Oct 5, 2022
@ddimatos ddimatos self-assigned this Oct 5, 2022
@ddimatos ddimatos added the In Progress This issue is under review by a team member. label Oct 5, 2022
Copy link
Collaborator

@fernandofloresg fernandofloresg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddimatos
Copy link
Collaborator Author

ddimatos commented Oct 5, 2022

Pipeline log suffix /job/zosAnsible/1248/console
image

@ddimatos ddimatos merged commit 8f0cf1c into release-v1.4.0-beta.2 Oct 5, 2022
@ddimatos ddimatos deleted the feature/329/job-output-dd_name-correction branch October 5, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as designed. In Progress This issue is under review by a team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants