-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] [zos_copy] Bugfixes for v1.3.6 #462
Conversation
This version of the fix is a port from the code present in 1.4.0-beta.2, except now the module only changes the permissions of the destination directory and new files inside of it, leaving alone preexisting files.
By taking Ketan's notes as a reference point, this commit does the following things: - Adds force and mode to the arg_spec of zos_copy - Adds encoding suboptions to the arg_spec of zos_copy, zos_fetch and zos_job_submit - Reorders the arg_spec to match documentation for zos_backup_restore, zos_copy, zos_data_set, zos_encode, zos_fetch, zos_job_submit, zos_lineinfile, zos_mvs_raw Co-Authored-By: ketankelkar <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
…r in the build Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
@rexemin - could you please look at what appears to be regression from the previous version (unless intentional) where copying a directory from src to target seems only to copy the src directory contents. We might have not proper test coverage, ill take a look later at that but wanted to note it for now. In 1.3.5 (previous version)
Yields this a directory
In this PR (1.3.6) only the contents are copied into
|
A new pull request will be performed for a new zos_copy module enhancement that will support directory copies as well, given this was the intended design at the time and all test cases passed, there is no reason to post pone this merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, lots of good work here, I am going to merge it and as we discussed a new PR and issue to support copying directories as well for zos_copy module.
SUMMARY
Fixes for
src
is a directory anddest
is a directory, if mode is set they are ignored #411 (mode gets ignored when copying between directories)zos_job_output
had DD's truncated, fix was in module_utilsjob.py
zos_ssh
used by withzos_ping
fails with an attribute error when used withansible-core
v2.11ISSUE TYPE
COMPONENT NAME
zos_copy
ADDITIONAL INFORMATION
For #411: When using
mode
in zos_copy and copying between directories, the given permissions are applied to the destination directory and any files that were not already present in it. Preexisting files and subdirectories are left with the same permissions they had before running the module.For #412:
force
was added to thearg_spec
of the module.