Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes zos_operator verbosity and excessive lines in content returned #400

Merged
merged 6 commits into from
Sep 6, 2022

Conversation

ddimatos
Copy link
Collaborator

@ddimatos ddimatos commented Sep 2, 2022

SUMMARY

This fixes the issue where the verbosity was not returned when a user set it to True. It also fixes the extra empty lines returned in the response in the content field.

It also updates the documentation to remove the security references under verbosity as that no longer supported content.

Fixes #397
Fixes #399

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zos_operator

ADDITIONAL INFORMATION

Before:

ok: [zvm] => {
    "result": {
        "changed": true,
        "cmd": "d t",
        "content": [
            "EC33017A   2022245  13:14:52.00             ISF031I CONSOLE OMVS0000 ACTIVATED",
            "EC33017A   2022245  13:14:52.00            -D T ",
            "EC33017A   2022245  13:14:52.00             IEE136I LOCAL: TIME=13.14.50 DATE=2022.245  UTC: TIME=20.14.50 DATE=2022.245",
            "",
            ""
        ],
        "elapsed": 9.16,
        "failed": false,
        "rc": 0,
        "wait_time_s": 10
    }
}

After:

ok: [zvm] => {
    "result": {
        "changed": true,
        "cmd": "d t",
        "content": [
            "EC33017A   2022245  13:25:09.00             ISF031I CONSOLE OMVS0000 ACTIVATED",
            "EC33017A   2022245  13:25:09.00            -D T ",
            "EC33017A   2022245  13:25:09.00             IEE136I LOCAL: TIME=13.25.07 DATE=2022.245  UTC: TIME=20.25.07 DATE=2022.245",
            "BGYSC0804I Using timeout of 10 seconds.",
            "BGYSC0801I CONSBUFPGNUM=128 - Console command output buffer memory size to be allocated: 131072 bytes",
            "BGYSC0802I Console command returned output string size of 77 bytes."
        ],
        "elapsed": 8.43,
        "failed": false,
        "rc": 0,
        "wait_time_s": 10
    }
}

@ddimatos ddimatos changed the title Bugfix/397 399/zos operator verbose lines Fixes zos_operator verbosity and excessive lines in content returned Sep 3, 2022
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
@ddimatos
Copy link
Collaborator Author

ddimatos commented Sep 3, 2022

image

Regression completed, internal link/log

@ddimatos ddimatos marked this pull request as ready for review September 3, 2022 05:35
Copy link
Collaborator

@fernandofloresg fernandofloresg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Good to add a long running command for testing.

Copy link
Collaborator

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking you to check slack for one minor question.

@ddimatos
Copy link
Collaborator Author

ddimatos commented Sep 6, 2022

FYI on the command used for the long running job;
By combining RO *ALL,cmd with a cmd that doesn't have a command response like RO *ALL,LOG 'dummy syslog message' the RO command processor will wait for 30 seconds before responding that it didn't receive any messages.

@ddimatos ddimatos merged commit 7223781 into dev Sep 6, 2022
@ddimatos ddimatos deleted the bugfix/397-399/zos-operator-verbose-lines branch September 6, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants