Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge version 1.3.4 release content to support branch #328

Merged
merged 21 commits into from
Jun 10, 2022

Conversation

ddimatos
Copy link
Collaborator

@ddimatos ddimatos commented Jun 2, 2022

SUMMARY
  • zos_ssh connection plugin was updated to correct a bug in Ansible that

    would result in playbook task retries overriding the SSH connection
    retries. This is resolved by renaming the zos_ssh option
    retries to reconnection_retries. The update addresses users of
    ansible-core v2.9 which continues to use retries and users of
    ansible-core v2.11 or later which uses reconnection_retries.

  • This also resolves a bug in the connection that referenced a deprecated
    constant.

  • This change also introduces the use of changelog and includes all the backdated changes and fragments for historical purposes.

  • Renames requirements-zos-core.txt to requirements.txt

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

samdoran and others added 15 commits May 31, 2022 21:11
There was a bug in Ansible that would result in task retries
overriding the connection retries. Using a different name for the
connection retries setting avoids this issue on versions of
Ansible that are missing the bug fix.
Resolves the usage of a non-existent constant that looks to
have been removed around ansible-core 2.4. Adds logic to
support users currently on ansible-core 2.9 and later. This
issue relates to upstream community changes:

 -  task_executor: use correct value for ssh connection retries

Pull request #75155
Signed-off-by: ddimatos <[email protected]>
…line emphasis start-string without end-string.

Signed-off-by: ddimatos <[email protected]>
@ddimatos ddimatos self-assigned this Jun 7, 2022
@ddimatos ddimatos added the Bug Something isn't working as designed. label Jun 7, 2022
@ddimatos ddimatos marked this pull request as ready for review June 7, 2022 00:13
@ddimatos
Copy link
Collaborator Author

ddimatos commented Jun 7, 2022

Ran the latest galaxy importer 0.4.5 to ensure compliance when released to Hub and Galaxy with no issues:

(venv) python -m galaxy_importer.main ibm-ibm_zos_core-1.3.4.tar.gz
Importing with galaxy-importer 0.4.5
Getting doc strings via ansible-doc
Finding content inside collection
Loading module zos_data_set
Loading module zos_ping
Loading module zos_encode
Loading module zos_job_output
Loading module zos_operator_action_query
Loading module zos_find
Loading module zos_mvs_raw
Loading module zos_backup_restore
Loading module zos_lineinfile
Loading module zos_copy
Loading module zos_apf
Loading module zos_tso_command
Loading module zos_job_query
Loading module zos_job_submit
Loading module zos_operator
Loading module zos_fetch
Loading module zos_blockinfile
Loading module_utils better_arg_parser
Loading module_utils mvs_cmd
Loading module_utils backup
Loading module_utils system
Loading module_utils encode
Loading module_utils job
Loading module_utils vtoc
Loading module_utils zos_mvs_raw
Loading module_utils copy
Loading module_utils ansible_module
Loading module_utils file
Loading module_utils dd_statement
Loading module_utils data_set
Loading module_utils import_handler
Loading action zos_ping
Loading action zos_copy
Loading action zos_job_submit
Loading action zos_fetch
Loading connection zos_ssh
Loading filter wtor
WARNING: Ignore files skip ansible-test sanity tests, found ignore-2.11.txt with 31 statement(s)
WARNING: Ignore files skip ansible-test sanity tests, found ignore-2.10.txt with 32 statement(s)
WARNING: Ignore files skip ansible-test sanity tests, found ignore-2.12.txt with 32 statement(s)
WARNING: Ignore files skip ansible-test sanity tests, found ignore-2.9.txt with 32 statement(s)
Collection loading complete
Importer processing completed successfully

@ddimatos
Copy link
Collaborator Author

ddimatos commented Jun 7, 2022

@ddimatos ddimatos requested a review from rexemin June 7, 2022 15:52
Copy link
Collaborator

@rexemin rexemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the changes, good call on adding the changelog and the history for every module. I just noticed that the values for version_added in zos_lineinfile, zos_operator and zos_tso_command have small typos:

  • zos_lineinfile has '1.3.0' but was added on '1.2.0'
  • zos_operator has '1.0.0' but was added on '1.1.0'
  • zos_tso_command has '1.0.0' but was added on '1.1.0'

But they're really small things, everything else looks pretty good.

@ddimatos
Copy link
Collaborator Author

ddimatos commented Jun 7, 2022

@rexemin
That was a good catch, I will update, the only thing that I have to tweak is the zos_lineinfile because we don't have a 1.2.0 release in Automation Hub because there was a issue with the upload so we had to bump the version to 1.2.1 thus I have marked zos_lineinfile releasing as 1.2.1.

1.2.1 and 1.2.0 was the same code, unfortunately we had an issue with the galaxy importer and had to bump the version.

I corrected the rest.

Copy link
Collaborator

@rexemin rexemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the changelog for the 3 modules I mentioned. As I said before, everything looks pretty good.

@ddimatos ddimatos closed this Jun 7, 2022
@ddimatos ddimatos reopened this Jun 7, 2022
@ddimatos ddimatos closed this Jun 8, 2022
@ddimatos ddimatos reopened this Jun 8, 2022
@ddimatos ddimatos closed this Jun 9, 2022
@ddimatos ddimatos reopened this Jun 9, 2022
@ddimatos
Copy link
Collaborator Author

@ddimatos ddimatos merged commit 208eff9 into support/1.3.x Jun 10, 2022
@ddimatos ddimatos deleted the bugfix/1.3.4 branch June 10, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as designed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants