-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge version 1.3.4 release content to support branch #328
Conversation
There was a bug in Ansible that would result in task retries overriding the connection retries. Using a different name for the connection retries setting avoids this issue on versions of Ansible that are missing the bug fix.
Resolves the usage of a non-existent constant that looks to have been removed around ansible-core 2.4. Adds logic to support users currently on ansible-core 2.9 and later. This issue relates to upstream community changes: - task_executor: use correct value for ssh connection retries Pull request #75155 Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
…line emphasis start-string without end-string. Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Ran the latest galaxy importer 0.4.5 to ensure compliance when released to Hub and Galaxy with no issues:
|
…failing sanity tests so restoring Signed-off-by: ddimatos <[email protected]>
…re going to pass Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look at the changes, good call on adding the changelog and the history for every module. I just noticed that the values for version_added
in zos_lineinfile
, zos_operator
and zos_tso_command
have small typos:
- zos_lineinfile has '1.3.0' but was added on '1.2.0'
- zos_operator has '1.0.0' but was added on '1.1.0'
- zos_tso_command has '1.0.0' but was added on '1.1.0'
But they're really small things, everything else looks pretty good.
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
Signed-off-by: ddimatos <[email protected]>
@rexemin 1.2.1 and 1.2.0 was the same code, unfortunately we had an issue with the galaxy importer and had to bump the version. I corrected the rest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the changelog for the 3 modules I mentioned. As I said before, everything looks pretty good.
SUMMARY
zos_ssh
connection plugin was updated to correct a bug in Ansible thatwould result in playbook task
retries
overriding the SSH connectionretries
. This is resolved by renaming thezos_ssh
optionretries
toreconnection_retries
. The update addresses users ofansible-core
v2.9 which continues to useretries
and users ofansible-core
v2.11 or later which usesreconnection_retries
.This also resolves a bug in the connection that referenced a deprecated
constant.
This change also introduces the use of changelog and includes all the backdated changes and fragments for historical purposes.
Renames requirements-zos-core.txt
torequirements.txt
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION