Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2635/zos gather facts #322

Merged
merged 53 commits into from
Aug 25, 2022
Merged

Feature/2635/zos gather facts #322

merged 53 commits into from
Aug 25, 2022

Conversation

ketankelkar
Copy link
Collaborator

SUMMARY

Adds zos_gather_facts module to the collection. This module leverages the zinfo utility offered by ZOAU 1.2.1 and later.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

zos_gather_facts

ADDITIONAL INFORMATION

@ketankelkar
add module with initial interface
a580fe6
@ketankelkar
add details to description
1b7c0a5
@ketankelkar
implement fact gather for python fact gatherer only
8bd6e6a
@ketankelkar
create separate file for collectors
4fd0df9
@ketankelkar
minor update to docs/comments
61b6335
@ketankelkar
add protype list of collectors to run against z and a protoype zos ba…
44adf4b 
…sed collector
@ketankelkar
import compatible ansible core engine collectors
19e17aa
@ketankelkar
add provision (in the form of commected code) to add zos collectors d…
c08cb91 
…own the road
@ketankelkar
remove incorrect local import
48ca213
@ketankelkar
update filter parameter to type string to be consistent with pre-2.11…
fb298f9 
… ansible
@ketankelkar
preliminary test suite for zos_gather_facts module
381fe64
@ketankelkar
break up monolith test into several tests
d51b3e1
@ketankelkar
update test names to accurately reflect module name
40a65cf
@ketankelkar
fprototype fact gathering with zoau integration work in progress
c9c029d
@ketankelkar
cleanup exploratory code snippets, improve var naming
3b94ccb
@ketankelkar
add logic to collector to run zinfo on uss and parse output
cbc81d3
@ketankelkar
merge dev -- bring fact gather branch up to date
628d65b
@ketankelkar
cleanup files from early exploratory work
f9cae26
@ketankelkar
adds ansible module basics
13f121f
@ketankelkar
flatten zinfo json to match builtin fact gathering behavior in ansibl…
67cdcd9 
…e_facts
@ketankelkar
add gather_subset option with minimal error handling
a5c244b
@ketankelkar
add comment blocks to helper functions, add additional comments throu…
9766158 
…ghout module
@ketankelkar
add initial unit tests for fact gathering
ca5b14c
@ketankelkar
add basic functional tests for fact gathering
b308059
@ketankelkar
implement filter parameter and corresponding unit and functional tests
0b48446
@ketankelkar
clean up comments
04efe26
@ketankelkar
expand on existing test cases, add notes for additional test cases
83a730d
@ketankelkar
address edge cases and bad input in helper functions
affbae7
@ketankelkar
add tests around bad or malicious input
24e234b
@ketankelkar
add/update comments and doc strings
f1c2765
@ketankelkar ketankelkar marked this pull request as ready for review May 2, 2022 17:08
ddimatos
ddimatos reviewed Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@ddimatos ddimatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I updated most of these, waiting on a regression test to complete.

@ddimatos
Copy link
Collaborator

Regression completed
image

Internal regression link/log

@ddimatos
Add changelog fragment for the pull request
bfc90d3 
Signed-off-by: ddimatos <[email protected]>
@ddimatos
Merge branch 'dev' into feature/2635/zos-gather-facts
e714a63 
 Conflicts:
	tests/functional/modules/test_zos_copy_func.py
        tests/functional/modules/test_zos_operator_action_query_func.py
	tests/sanity/ignore-2.11.txt
	tests/sanity/ignore-2.13.txt
@ddimatos
Merge branch 'dev' into feature/2635/zos-gather-facts
5cb65a6
@ddimatos ddimatos self-requested a review August 25, 2022 04:38
@ddimatos
Copy link
Collaborator

Thanks @ketankelkar , been looking forward to this.

@ddimatos ddimatos merged commit c2ea7ff into dev Aug 25, 2022
@ddimatos ddimatos deleted the feature/2635/zos-gather-facts branch August 25, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddimatos ddimatos ddimatos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ketankelkar @ddimatos @jennyhuang17