Bugfix/8877/Fixes deletion of src on encoding error #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code failed while trying to copy files from a directory that needs to be converted, dirs_exist_ok=True should fix that. Additionally, I added two checks to always make sure that we don't accidentally delete source files when they're not temporary.
rexemin
changed the title
Quick workaround for a failing test in zos_copy. The test has been fixed more permanently in v1.3.3 of the collection.
richp405
requested changes
Jul 8, 2022
ddimatos
changed the title
Conflicts: tests/functional/modules/test_zos_copy_func.py
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code failed while trying to copy files from a directory that needs to be converted, dirs_exist_ok=True should fix that. Additionally, I added two checks to always make sure that we don't accidentally delete source files when they're not temporary.
SUMMARY
Fixes NAZARE-8877: deletion of source files when encoding conversion fails.
ISSUE TYPE
COMPONENT NAME
zos_copy
ADDITIONAL INFORMATION
The bugfix will also change test cases a bit to make sure the module doesn't delete source files when encoding conversion fails.