Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ac tool version of pyyaml to avoid wheel issue #1083

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

ddimatos
Copy link
Collaborator

@ddimatos ddimatos commented Dec 4, 2023

SUMMARY

Addresses issue #1081 and #1082.

This fixes 2 issues, it freezes PyYAML to 6.0.1 to address the bug reported here which leaves pip unable to use a wheel for versions 5.4.1. It also enhances the tool to search for Pythons not in PATH to aid in the ac tool decision on which Python to use to build a venv from, .ac always uses the latest python it discovers.

@ddimatos ddimatos requested review from rexemin and richp405 December 4, 2023 21:25
@ddimatos ddimatos marked this pull request as ready for review December 4, 2023 21:26
Copy link
Collaborator

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't realize you could list without commas in shell script.

@richp405 richp405 merged commit 989cc14 into dev Dec 4, 2023
@ddimatos ddimatos deleted the enhancement/1081-1082/update-ac-tool-pyyaml-version branch December 4, 2023 21:45
@ddimatos
Copy link
Collaborator Author

ddimatos commented Dec 4, 2023

didn't realize you could list without commas in shell script.

:) , If i recall i went with spaces instead of commas to normalize on representation for different shell types, you might find this function of interest.

# Private function that initializes an array ($1) from a properly delimited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants