Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enabler] [Dev] [module_utils/encode.py] Migrate module, module utilities and test cases to ZOAU 1.3 #1120

Closed
Tracked by #931
ddimatos opened this issue Dec 20, 2023 · 0 comments · Fixed by #1189
Closed
Tracked by #931
Assignees
Labels
Enabler Enabler task In Plan Issue has been accepted put into a planned release

Comments

@ddimatos
Copy link
Collaborator

ddimatos commented Dec 20, 2023

module_utils

encode.py

See Epic

[Enabler] [Epic] Adopt new ZOAU 1.3 Python changes

Enabler description

With the adoption of ZOAU 1.3, modules, module utilities and test cases may need to be updated according to the migration guide.

APIs changes affecting module:

  • Impacted by ZOAU Dataset API: Yes
  • Impacted by ZOAU jobs API: No
  • Impacted by the rename of types.py to ztypes.py: No
  • Impacted by the contents of module volumes.py having been moved to datasets.py: No
  • Impacted by opercmd timeout to milli seconds: No
  • Impacted by JSON schema change: No
  • Impacted by Exceptions schema: No

Review the zoautil_py datasets module migration doc.

Upon review, this module is affected by:

  • the dataset class being relocated to zoautil_py.datasets.Dataset.
    • See from zoautil_py import datasets
  • the function datasets.hlq() is renamed to datasets.get_hlq()
    • see hlq = datasets.hlq()
  • the function datasets.tmp_name() the parameter hlq is renamed to high_level_qualifier
    • see temp_ps = datasets.tmp_name(hlq)

This issue depends on shared import identified by git issues:

The dependency finder found this util use imported by these sources:

  • /tests/functional/modules/test_zos_copy_func.py
  • /tests/functional/modules/test_zos_archive_func.py
  • /tests/functional/modules/test_zos_unarchive_func.py
  • /tests/functional/modules/test_zos_script_func.py
  • /tests/functional/modules/test_zos_lineinfile_func.py
  • /tests/functional/modules/test_zos_encode_func.py
  • /tests/functional/modules/test_zos_data_set_func.py
  • /tests/functional/modules/test_module_security.py
  • /tests/functional/modules/test_zos_job_submit_func.py
  • /tests/functional/modules/test_zos_fetch_func.py
  • /tests/functional/modules/test_zos_mount_func.py
  • /tests/functional/modules/test_zos_job_query_func.py
  • /tests/functional/modules/test_zos_blockinfile_func.py
  • /tests/functional/modules/test_zos_job_output_func.py
@ddimatos ddimatos added the Enabler Enabler task label Dec 20, 2023
@ddimatos ddimatos changed the title [Enabler] [] Migrate module, module utilities and test cases to ZOAU 1.3 [Enabler] [module_utils/encode.py] Migrate module, module utilities and test cases to ZOAU 1.3 Dec 20, 2023
@ddimatos ddimatos added this to the [Q1] [2024] Enablers milestone Dec 20, 2023
@ddimatos ddimatos changed the title [Enabler] [module_utils/encode.py] Migrate module, module utilities and test cases to ZOAU 1.3 [Enabler] [Dev] [module_utils/encode.py] Migrate module, module utilities and test cases to ZOAU 1.3 Dec 28, 2023
@ddimatos ddimatos added the In Plan Issue has been accepted put into a planned release label Jan 3, 2024
@fernandofloresg fernandofloresg moved this from 📗In plan to 🏗 In progress in IBM Ansible z/OS Core Collection Jan 26, 2024
@fernandofloresg fernandofloresg moved this from 🏗 In progress to 🔍 Validation in IBM Ansible z/OS Core Collection Jan 26, 2024
@fernandofloresg fernandofloresg moved this from 🔍 Validation to ✅ Done in IBM Ansible z/OS Core Collection Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enabler Enabler task In Plan Issue has been accepted put into a planned release
Projects
4 participants