Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enabler] [Dev] [zos_archive] Migrate module, module utilities and test cases to ZOAU 1.3 #1103

Closed
Tracked by #931
ddimatos opened this issue Dec 19, 2023 · 0 comments · Fixed by #1227
Closed
Tracked by #931
Assignees
Labels
Enabler Enabler task In Plan Issue has been accepted put into a planned release

Comments

@ddimatos
Copy link
Collaborator

ddimatos commented Dec 19, 2023

Is there an existing issue for this?

Ansible module

zos_archive

See Epic

[Enabler] [Epic] Adopt new ZOAU 1.3 Python changes

Enabler description

With the adoption of ZOAU 1.3, modules, module utilities and test cases may need to be updated according to the migration guide.

APIs changes affecting module:

  • Impacted by ZOAU Dataset API: Yes
  • Impacted by ZOAU jobs API: No
  • Impacted by the rename of types.py to ztypes.py: No
  • Impacted by the contents of module volumes.py having been moved to datasets.py: No
  • Impacted by opercmd timeout to milli seconds: No
  • Impacted by JSON schema change in either apfadm, dmod, dsed or zinfo: No
  • Impacted by Exceptions schema: No

Review the zoautil_py datasets module migration doc.

Upon review, this module is affected by:

  • the dataset class being relocated to zoautil_py.datasets.Dataset.
    • See from zoautil_py import datasets
  • the function datasets.listing() being renamed to list_datasets()
    • see calls to datasets.listing such as datasets.listing(path)
  • the function Dataset.to_dict() is deprecated. Use vars(Dataset) or Dataset.dict to get a dictionary containing all dataset attributes.
    • see:
                  for target in self.targets:
                      data_sets = datasets.listing(target)
                      for ds in data_sets:
                          dest_space += int(ds.to_dict().get("total_space"))
      

This issue depends on shared import identified by git issues:

@ddimatos ddimatos added the Enabler Enabler task label Dec 19, 2023
@ddimatos ddimatos added this to the [Q1] [2024] Enablers milestone Dec 20, 2023
@ddimatos ddimatos changed the title [Enabler] [zos_archive] Migrate module, module utilities and test cases to ZOAU 1.3 [Enabler] [Dev] [zos_archive] Migrate module, module utilities and test cases to ZOAU 1.3 Dec 28, 2023
@ddimatos ddimatos added the In Plan Issue has been accepted put into a planned release label Jan 3, 2024
@fernandofloresg fernandofloresg moved this from 📗In plan to 🏗 In progress in IBM Ansible z/OS Core Collection Feb 15, 2024
@fernandofloresg fernandofloresg moved this from 🏗 In progress to 🔍 Validation in IBM Ansible z/OS Core Collection Feb 16, 2024
@fernandofloresg fernandofloresg moved this from 🔍 Validation to ✅ Done in IBM Ansible z/OS Core Collection Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enabler Enabler task In Plan Issue has been accepted put into a planned release
Projects
Development

Successfully merging a pull request may close this issue.

3 participants