Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoding option to API modules #95

Merged
merged 3 commits into from
May 24, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes one of the issues mentioned in #91 (comment). Note that encoding='UTF-8' doesn't properly work without luqasz/librouteros#131.

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

API modules

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #95 (ff66ba9) into main (ff66ba9) will not change coverage.
The diff coverage is n/a.

❗ Current head ff66ba9 differs from pull request most recent head 9b27e05. Consider uploading reports for the commit 9b27e05 to get more accurate results

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files          25       25           
  Lines        2487     2487           
  Branches      432      432           
=======================================
  Hits         2085     2085           
  Misses        313      313           
  Partials       89       89           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff66ba9...9b27e05. Read the comment docs.

@felixfontein
Copy link
Collaborator Author

I think once this one is merged, we can create a new release so that folks can try out the new features and modules. Then we also don't have too much pressure on #91 ;)

Copy link
Collaborator

@NikolayDachev NikolayDachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and work as expected, let's merge

@NikolayDachev
Copy link
Collaborator

NikolayDachev commented May 24, 2022

side note: probably we should add few words for the new modules also for encoding: in git README

@felixfontein
Copy link
Collaborator Author

side note: probably we should add few words for the new modules also for encoding: in git README

Good point, I'll write something in a follow-up PR.

@felixfontein felixfontein merged commit 023f11f into ansible-collections:main May 24, 2022
@felixfontein felixfontein deleted the encoding branch May 24, 2022 20:19
@felixfontein
Copy link
Collaborator Author

@NikolayDachev thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants