-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encoding option to API modules #95
Conversation
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 83.83% 83.83%
=======================================
Files 25 25
Lines 2487 2487
Branches 432 432
=======================================
Hits 2085 2085
Misses 313 313
Partials 89 89 Continue to review full report at Codecov.
|
I think once this one is merged, we can create a new release so that folks can try out the new features and modules. Then we also don't have too much pressure on #91 ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and work as expected, let's merge
side note: probably we should add few words for the new modules also for |
Good point, I'll write something in a follow-up PR. |
@NikolayDachev thanks for reviewing this! |
SUMMARY
Fixes one of the issues mentioned in #91 (comment). Note that
encoding='UTF-8'
doesn't properly work without luqasz/librouteros#131.ISSUE TYPE
COMPONENT NAME
API modules