KeyInfo: prevent read_only usage with can_disable, remove_value, absent_value, default, or required #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default, or required.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 82.97% 82.99% +0.02%
==========================================
Files 32 32
Lines 4046 4051 +5
Branches 871 873 +2
==========================================
+ Hits 3357 3362 +5
Misses 506 506
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
derdeagle
approved these changes
Mar 3, 2024
|
@derdeagle thanks for reviewing this! |
samburney
pushed a commit
to samburney/community.routeros
that referenced
this pull request
Mar 30, 2024
…nt_value, default, or required (ansible-collections#265) * Prevent read_only usage with can_disable, remove_value, absent_value, default, or required. * Add test.
samburney
pushed a commit
to samburney/community.routeros
that referenced
this pull request
Mar 30, 2024
…nt_value, default, or required (ansible-collections#265) * Prevent read_only usage with can_disable, remove_value, absent_value, default, or required. * Add test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Ref: #264 (comment)
ISSUE TYPE
COMPONENT NAME
_api_data.py