Fix snmp path's engine-id/engine-id-suffix for ROS 7.10+ #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage 83.15% 83.15%
=======================================
Files 32 32
Lines 4031 4031
Branches 867 867
=======================================
Hits 3352 3352
Misses 494 494
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
felixfontein
force-pushed
the
snmp-engine-suffix
branch
from
e3f4874 to
da9c2cc
Compare
derdeagle
approved these changes
Sep 17, 2023
|
@derdeagle if you mean the ability to distinguish on the ROS version, that's pretty new (#209, #212) :) |
|
@felixfontein That's exactly what I meant, very well! I didn't have the chance to take a look at the latest changes unfortunately. Great work! |
|
@derdeagle thanks for reviewing this! |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #208.
CC @phox142 @derdeagle (#217) - PTAL!
ISSUE TYPE
COMPONENT NAME
API data