-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wireguard interface and peers #143
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Can you please add a changelog fragment? Thanks.
Hmm, that's unfortunate. We probably should document this behavior, and/or have some special code to handle this in a sane (and preferably user-configurable) way. |
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
=======================================
Coverage 67.44% 67.44%
=======================================
Files 2 2
Lines 172 172
Branches 39 39
=======================================
Hits 116 116
Misses 40 40
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I feel like there has to be a way to actually get this information from the API, I can try asking them directly. In the CLI the private key is hidden unless using export (without hide-sensitive at least). If there isn't, we could add a |
@felixfontein I've figured out the issue with private-key and edited the description, it was my fault for not giving my API user enough permissions. Let me know if there's anything more I should do to get this merged, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to hear! I have one small comment for the changelog fragment, besides that it looks good!
@cosandr thanks for your contribution! |
SUMMARY
Adds support for configuring wireguard interfaces and peers.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Missing tests and equally as important,
interface wireguard
editing doesn't behave as expected (misconfiguration error, see below). The API obfuscates the value ofprivate-key
so the diff is broken, for example:This happens even if that private key is already configured on the router. I was unable to find documentation on how to get the API to return sensitive information like this.
UPDATE: This is fixed by adding the "sensitive" policy to the group used to connect.
After that, the private-key is returned and diff works as expected.