Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths #137

Merged
merged 10 commits into from
Nov 29, 2022
Merged

Paths #137

merged 10 commits into from
Nov 29, 2022

Conversation

therfert
Copy link
Contributor

SUMMARY
  • api_info, api_modify - support API paths - interface ethernet poe, interface gre6, interface vrrp and also support for all previously missing fields of entries in ip dhcp-server

  • api_info, api_modify - address-pool field of entries in API path ip dhcp-server is not required anymore

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

api_*

Tomas Herfert added 4 commits November 22, 2022 21:25
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #137 (b61587a) into main (4ed2fc8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   87.54%   87.54%           
=======================================
  Files          28       28           
  Lines        3597     3597           
  Branches      638      638           
=======================================
  Hits         3149     3149           
  Misses        315      315           
  Partials      133      133           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.29% <ø> (ø)
units 87.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_api_data.py 95.91% <ø> (ø)
plugins/modules/api_info.py 90.14% <ø> (ø)
plugins/modules/api_modify.py 79.09% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Tomas Herfert added 5 commits November 28, 2022 22:24
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
@github-actions
Copy link

github-actions bot commented Nov 28, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

@therfert therfert marked this pull request as ready for review November 28, 2022 21:59
@felixfontein felixfontein merged commit 4376906 into ansible-collections:main Nov 29, 2022
@felixfontein
Copy link
Collaborator

@therfert thanks for your contribution!

@therfert therfert deleted the paths branch December 6, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants