-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed integration tests #462
Conversation
cc @JohnAtOlo |
@aleksvagachev as #463 seems solving the issue (thanks for spotting the cause!) I think you could cancel the changes in tests here and focus on tidying up the function like removing that param_dict and i think maybe those checks can be also replaced with functions from module_utils.postgres or removed |
@aleksvagachev @hunleyd thanks! UPDATE: ah, i mixed up folks, sorry, @aleksvagachev anyway #462 (comment) is still relevant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cool, let's merge it, thanks everyone:) the function can still be improved more as an idea for further contributions. |
@aleksvagachev once you're back from PTO, could you please backport this PR manually? |
SUMMARY
Due to a change in the receipt of connection parameters in postgresql_privs ( #451 ), fixed the integration tests.