Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_query: add as_single_query new option #37

Merged
merged 6 commits into from
Jan 14, 2021
Merged

postgresql_query: add as_single_query new option #37

merged 6 commits into from
Jan 14, 2021

Conversation

Andersson007
Copy link
Collaborator

@Andersson007 Andersson007 commented Dec 29, 2020 •
edited
Loading

SUMMARY

Fixes #34

Partial revert of ansible-collections/community.general#886

postgresql_query: add as_single_query new option

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

postgresql_query

@Andersson007 Andersson007 changed the title [WIP] postgresql_query: add single_query new option postgresql_query: add single_query new option Dec 29, 2020
@Andersson007 Andersson007 mentioned this pull request Dec 29, 2020
Closed
@Andersson007
Copy link
Collaborator Author

I'm not sure i chose the best name for the option. Maybe as_single_query or something else would be better?

@Andersson007 Andersson007 changed the title postgresql_query: add single_query new option postgresql_query: add as_single_query new option Dec 30, 2020
@Andersson007
Copy link
Collaborator Author

changed single_query to as_single_query staying open for other options

@Andersson007
Copy link
Collaborator Author

ready_for_review

@Andersson007
Copy link
Collaborator Author

cc @pmauduit @ilicmilan @kostiantyn-nemchenko @tcraxs

pmauduit
pmauduit approved these changes Jan 7, 2021
View reviewed changes
Copy link

@pmauduit pmauduit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andersson007
Copy link
Collaborator Author

@pmauduit thanks for reviewing!

@Andersson007 Andersson007 merged commit d271732 into ansible-collections:main Jan 14, 2021
@Andersson007 Andersson007 mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmauduit pmauduit pmauduit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

postgresql_query - loading script fails if script contain plpgsql definitions
2 participants
@Andersson007 @pmauduit