-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix encoding errors on Windows guests (fixes: #156) #157
Conversation
@leegarrett looks good to me, thanks! Any chance you could add a changelog fragment as well at |
hi everyone, here's the changelog fragment docs link https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment |
Done! |
/rebuild |
/azp run CI (Remote 2.13 FreeBSD 13.0) |
No pipelines are associated with this pull request. |
/azp run CI |
Azure Pipelines successfully started running 1 pipeline(s). |
@leegarrett sorry for the noise, we were having trouble getting the pipeline to re-run.. The sanity checks are failing at the moment, I will take a look when I get some time and get back to you. |
@leegarrett I've fixed up the CI issues in another branch which has since merged #158, do you mind rebasing your branch when you get a moment? Thanks! |
On Windows guests the default encoding will be set to whatever default legacy encoding, not utf-8. This issue isn't apparent on English locale Windows guests, as there the encodings (ISO-8859-1, utf-8) happen to coincide. However, on e.g. German Windows guests this will cause an encoding error when reading any output from there. This patch ensures that the proper encoding is set on every command.
And done! |
@leegarrett great thanks for the contribution! |
On Windows guests the default encoding will be set to whatever default legacy encoding, not utf-8. This issue isn't apparent on English locale Windows guests, as there the encodings (ISO-8859-1, utf-8) happen to coincide.
However, on e.g. German Windows guests this will cause an encoding error when reading any output from there.
This patch ensures that the proper encoding is set on every command.