Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test helper: fix parameter passing in creation static method #9662

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Feb 1, 2025

SUMMARY

Parameter mocks was not being passed from Helper.from_module() to Helper.from_file() as it should.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

tests/unit/plugins/modules/helper.py

@ansibullbot ansibullbot added small_patch Hopefully easy to review tests tests unit tests/unit labels Feb 1, 2025
@felixfontein felixfontein added the backport-10 Automatically create a backport for the stable-10 branch label Feb 1, 2025
@felixfontein felixfontein merged commit 4d384bd into ansible-collections:main Feb 1, 2025
138 checks passed
Copy link

patchback bot commented Feb 1, 2025

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/4d384bd74a116b0855e7870e149a25e44c0bd296/pr-9662

Backported as #9663

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 1, 2025
@russoz russoz deleted the test-helper-fix branch February 1, 2025 10:01
felixfontein pushed a commit that referenced this pull request Feb 1, 2025
…ssing in creation static method (#9663)

test helper: fix parameter passing in creation static method (#9662)

(cherry picked from commit 4d384bd)

Co-authored-by: Alexei Znamensky <[email protected]>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 Automatically create a backport for the stable-10 branch small_patch Hopefully easy to review tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants