Update nmcli.py to support VRF commands #9658
Open
+156
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskaris
force-pushed
the
issue8014
branch
2 times, most recently
from
cc83425 to
1477271
Compare
ansibullbot
added
bug
andreaskaris
force-pushed
the
issue8014
branch
from
1477271 to
5bc0e86
Compare
This comment was marked as outdated.
This comment was marked as outdated.
andreaskaris
force-pushed
the
issue8014
branch
from
5bc0e86 to
07e5fb1
Compare
ansibullbot
removed
ci_verified
andreaskaris
force-pushed
the
issue8014
branch
from
07e5fb1 to
cd9e018
Compare
andreaskaris
force-pushed
the
issue8014
branch
from
cd9e018 to
8bdd804
Compare
Adding VRF support and documentation to the nmcli module Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
force-pushed
the
issue8014
branch
from
8bdd804 to
4e4d560
Compare
|
ready_for_review |
felixfontein
added
check-before-release
russoz
reviewed
Feb 1, 2025
There was a problem hiding this comment.
hi @andreaskaris thanks for your contribution!
Besides Felix's comment, one additional adjustment is needed in the changelog fragment, other than that, it LGTM! :-)
| @@ -0,0 +1,2 @@ | |||
| minor_changes: | |||
| - nmcli - adds VRF support with new ``type`` value ``vrf`` and new ``slave_type`` value ``vrf`` as well as new ``table`` parameter (https://github.com/ansible-collections/community.general/pull/9658). | |||
There was a problem hiding this comment.
Please add the URL of the issue being fixed as well:
Suggested change
| - nmcli - adds VRF support with new ``type`` value ``vrf`` and new ``slave_type`` value ``vrf`` as well as new ``table`` parameter (https://github.com/ansible-collections/community.general/pull/9658). | |
| - nmcli - adds VRF support with new ``type`` value ``vrf`` and new ``slave_type`` value ``vrf`` as well as new ``table`` parameter (https://github.com/ansible-collections/community.general/pull/9658, https://github.com/ansible-collections/community.general/issues/8014). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding VRF support and documentation to the nmcli module
Fixes #8014
ISSUE TYPE
COMPONENT NAME
community.general.nmcli
ADDITIONAL INFORMATION