Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8900/a32f1d69 backport][stable-9] ipa_hostgroup: fix state params #8906

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Sep 23, 2024

This is a backport of PR #8900 as merged into main (a32f1d6).

SUMMARY

Fix state enabled and disabled params
Fixes #8408

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ipa_hostgroup

ADDITIONAL INFORMATION

As it was mentioned in a related issue these values for state: are useless and because of else statement the lead to absent result. It is not clear if these values should be kept because they do not work as intented so maybe we should just remove or deprecate them? For now i made it so 'absent'/'disabled' and 'present'/'enabled' are the same thing

# before
  - ipa_hostgroup:
      # 'present' works.
      # 'enabled' and 'disabled' behave equivalent to 'absent'
      state: 'enabled'
      name:  'testhostgroup'
      
# after
  - ipa_hostgroup:
      # 'present' is equivalent to 'enabled'
      state: enabled
      name:  'testhostgroup'
 
  - ipa_hostgroup:
      # 'absent' is equivalent to 'disabled'
      state: disabled
      name:  'testhostgroup'

* Fix ipa_hostgroup

* Add CHANGELOG fragment

(cherry picked from commit a32f1d6)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Sep 23, 2024
@felixfontein felixfontein merged commit 5343880 into stable-9 Sep 23, 2024
146 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-9/a32f1d699bffac90a4cbe11cb5c11a0851a6666e/pr-8900 branch September 23, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants