Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8557/6e0142fe backport][stable-8] bitwarden: Fix KeyError in search_field (#8549) #8562

Merged
merged 1 commit into from
Jun 27, 2024
Merged

[PR #8557/6e0142fe backport][stable-8] bitwarden: Fix KeyError in search_field (#8549) #8562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/8557-fix-bug-with-bitwarden.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- "bitwarden lookup plugin - fix ``KeyError`` in ``search_field`` (https://github.com/ansible-collections/community.general/issues/8549, https://github.com/ansible-collections/community.general/pull/8557)."
5 changes: 3 additions & 2 deletions plugins/lookup/bitwarden.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,9 @@ def _get_matches(self, search_value, search_field, collection_id=None, organizat
else:
initial_matches = [initial_matches]

# Filter to only include results from the right field.
return [item for item in initial_matches if not search_value or item[search_field] == search_value]
# Filter to only include results from the right field, if a search is requested by value or field
return [item for item in initial_matches
if not search_value or not search_field or item.get(search_field) == search_value]

def get_field(self, field, search_value, search_field="name", collection_id=None, organization_id=None):
"""Return a list of the specified field for records whose search_field match search_value
Expand Down