Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak_clientscope: add normalizations for attributes and protocol_mappers #8496

Conversation

yeoldegrove
Copy link
Contributor

@yeoldegrove yeoldegrove commented Jun 13, 2024

SUMMARY

keycloak_clientscope: Add sorted attributes and protocol_mappers to normalizations.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_clientscope

ADDITIONAL INFORMATION

Without this code, ansible-playbook --check --diffwill show changes because a unsorted list is diffed.
It uses the same approach as for keycloak_client in

def normalise_cr(clientrep, remove_ids=False):

@yeoldegrove yeoldegrove force-pushed the keycloak_clientscopes/add-normalizations branch from 8990dea to da195fe Compare June 13, 2024 07:29
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Jun 13, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch labels Jun 13, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

@yeoldegrove yeoldegrove force-pushed the keycloak_clientscopes/add-normalizations branch from da195fe to 5eca02a Compare June 13, 2024 21:34
@yeoldegrove
Copy link
Contributor Author

@felixfontein done

@yeoldegrove yeoldegrove requested a review from felixfontein June 13, 2024 21:35
@felixfontein
Copy link
Collaborator

Thanks for your contribution! If nobody objects, I'll merge it on Sunday.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 16, 2024
@felixfontein felixfontein merged commit fd2cd5f into ansible-collections:main Jun 16, 2024
134 checks passed
Copy link

patchback bot commented Jun 16, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/fd2cd5f28c7b2cc3b53f5366a94436a77f986dee/pr-8496

Backported as #8520

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Jun 16, 2024

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/fd2cd5f28c7b2cc3b53f5366a94436a77f986dee/pr-8496

Backported as #8521

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@yeoldegrove thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Jun 16, 2024
…alizations for attributes and protocol_mappers (#8520)

keycloak_clientscope: add normalizations for attributes and protocol_mappers (#8496)

Signed-off-by: Eike Waldt <[email protected]>
(cherry picked from commit fd2cd5f)

Co-authored-by: Eike Waldt <[email protected]>
felixfontein pushed a commit that referenced this pull request Jun 16, 2024
…alizations for attributes and protocol_mappers (#8521)

keycloak_clientscope: add normalizations for attributes and protocol_mappers (#8496)

Signed-off-by: Eike Waldt <[email protected]>
(cherry picked from commit fd2cd5f)

Co-authored-by: Eike Waldt <[email protected]>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants