-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keycloak_clientscope: add normalizations for attributes and protocol_mappers #8496
keycloak_clientscope: add normalizations for attributes and protocol_mappers #8496
Conversation
8990dea
to
da195fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Can you please add a changelog fragment? Thanks.
…mappers Signed-off-by: Eike Waldt <[email protected]>
da195fe
to
5eca02a
Compare
@felixfontein done |
Thanks for your contribution! If nobody objects, I'll merge it on Sunday. |
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8520 🤖 @patchback |
…mappers (#8496) Signed-off-by: Eike Waldt <[email protected]> (cherry picked from commit fd2cd5f)
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8521 🤖 @patchback |
…mappers (#8496) Signed-off-by: Eike Waldt <[email protected]> (cherry picked from commit fd2cd5f)
@yeoldegrove thanks for your contribution! |
…alizations for attributes and protocol_mappers (#8520) keycloak_clientscope: add normalizations for attributes and protocol_mappers (#8496) Signed-off-by: Eike Waldt <[email protected]> (cherry picked from commit fd2cd5f) Co-authored-by: Eike Waldt <[email protected]>
…alizations for attributes and protocol_mappers (#8521) keycloak_clientscope: add normalizations for attributes and protocol_mappers (#8496) Signed-off-by: Eike Waldt <[email protected]> (cherry picked from commit fd2cd5f) Co-authored-by: Eike Waldt <[email protected]>
…mappers (ansible-collections#8496) Signed-off-by: Eike Waldt <[email protected]>
SUMMARY
keycloak_clientscope: Add sorted
attributes
andprotocol_mappers
to normalizations.ISSUE TYPE
COMPONENT NAME
keycloak_clientscope
ADDITIONAL INFORMATION
Without this code,
ansible-playbook --check --diff
will show changes because a unsorted list is diffed.It uses the same approach as for
keycloak_client
incommunity.general/plugins/modules/keycloak_client.py
Line 730 in 6c8f949